ed09b19b1ba7

web: style changes, minor fixes
[view raw] [browse files]
author Steve Losh <steve@stevelosh.com>
date Sun, 13 Jun 2010 13:06:48 -0400
parents cec804c97165
children 22341c03b3c9
branches/tags (none)
files review/static/style.css review/static/style.less review/templates/changeset.html review/templates/index.html

Changes

--- a/review/static/style.css	Sun Jun 13 12:50:19 2010 -0400
+++ b/review/static/style.css	Sun Jun 13 13:06:48 2010 -0400
@@ -192,7 +192,8 @@
 #index .content table tr td {
   border: none;
 }
-#index .content table tr td a {
+#index .content table tr td a.changeset-link {
+  display: block;
   width: 100%;
   white-space: nowrap;
   overflow: hidden;
@@ -214,6 +215,7 @@
   text-align: right;
 }
 #index .content table tr td.stats .badge {
+  cursor: pointer;
   color: white;
   font-weight: bold;
   display: inline-block;
@@ -236,6 +238,9 @@
 #index .content table tr td.stats .badge.comments {
   background-color: #ff5700;
 }
+#index .content table tr td.stats .badge:hover {
+  text-decoration: none;
+}
 #changeset .content .fulldesc {
   font-size: 18px;
   line-height: 1.25;
--- a/review/static/style.less	Sun Jun 13 12:50:19 2010 -0400
+++ b/review/static/style.less	Sun Jun 13 13:06:48 2010 -0400
@@ -229,7 +229,8 @@
             td {
                 border: none;
 
-                a {
+                a.changeset-link {
+                    display: block;
                     width: 100%;
                     white-space: nowrap;
                     overflow: hidden;
@@ -253,6 +254,7 @@
                     text-align: right;
 
                     .badge {
+                        cursor: pointer;
                         color: white;
                         font-weight: bold;
                         display: inline-block;
@@ -274,6 +276,9 @@
                         &.comments {
                             background-color: @c-orange-light;
                         }
+                        &:hover {
+                            text-decoration: none;
+                        }
                     }
                 }
             }
--- a/review/templates/changeset.html	Sun Jun 13 12:50:19 2010 -0400
+++ b/review/templates/changeset.html	Sun Jun 13 13:06:48 2010 -0400
@@ -61,7 +61,7 @@
                         
                         <div>
                             <div class="author">
-                                <a href="mailto:{{ email(signoff.author) }}">{{ utils['templatefilters'].person(signoff.author) }}</a>
+                                <a href="mailto:{{ utils['email'](signoff.author) }}">{{ utils['templatefilters'].person(signoff.author) }}</a>
                                 signed off as <span class="opinion">{{ signoff.opinion or "neutral" }}</span> on this changeset, saying:
                             </div>
                             <div class="message">{{ signoff.message }}</div>
--- a/review/templates/index.html	Sun Jun 13 12:50:19 2010 -0400
+++ b/review/templates/index.html	Sun Jun 13 13:06:48 2010 -0400
@@ -9,10 +9,12 @@
         {% for rcset in rcsets %}
             {% set rev = rcset.target[rcset.node] %}
             {% set node_short = utils['node_short'](rev.node()) %}
+            {% set link = "/changeset/" + node_short %}
+
             <tr>
                 <td class="node"><span class="rev">{{ rev.rev() }}</span><span class="sep">:</span><span class="hash">{{ node_short }}</span></td>
                 <td class="desc">
-                    <a href="/changeset/{{ node_short }}/">{{  rev.description().splitlines()[0] }}</a>
+                    <a class="changeset-link" href="{{ link }}">{{  rev.description().splitlines()[0] }}</a>
                 </td>
                 <td class="stats">
                     {% with %}
@@ -20,17 +22,17 @@
                         {% set signoffs = utils['categorize_signoffs'](rcset.signoffs) %}
 
                         {% if comments %}
-                        <span class="badge comments">{{ utils['len'](comments) }} comment{% if utils['len'](comments) > 1 %}s{% endif %}</span>
+                        <a class="badge comments" href="{{ link }}">{{ utils['len'](comments) }} comment{% if utils['len'](comments) > 1 %}s{% endif %}</a>
                         {% endif %}
 
                         {% if signoffs['yes'] %}
-                            <span class="badge signoffs yes">{{ signoffs['yes'] }} yes</span>
+                            <a class="badge signoffs yes" href="{{ link }}">{{ signoffs['yes'] }} yes</a>
                         {% endif %}
                         {% if signoffs['neutral'] %}
-                            <span class="badge signoffs neutral">{{ signoffs['neutral'] }} neutral</span>
+                            <a class="badge signoffs neutral" href="{{ link }}">{{ signoffs['neutral'] }} neutral</a>
                         {% endif %}
                         {% if signoffs['no'] %}
-                            <span class="badge signoffs no">{{ signoffs['no'] }} no</span>
+                            <a class="badge signoffs no" href="{{ link }}">{{ signoffs['no'] }} no</a>
                         {% endif %}
                     {% endwith %}
                 </td>