Allow signoff to be added when one already exists on a precursor.

The current obsolescence support makes little difference between
comments/signoff from a cset and the ones from its predecessors.

This patch avoid a signoff from a precursor to be seen as changeable, and allow
the user to re-signoff on the latest version of the changeset.
[view raw] [browse files]
author Christophe de Vienne <cdevienne@gmail.com>
date Wed, 29 Oct 2014 14:32:27 +0100
parents f305fba940c0
children 676834353b0d
branches/tags (none)
files review/api.py


--- a/review/api.py	Tue Oct 28 11:16:39 2014 +0100
+++ b/review/api.py	Wed Oct 29 14:32:27 2014 +0100
@@ -482,7 +482,8 @@
     def signoffs_for_user(self, username):
-        return filter(lambda s: s.author == username, self.signoffs)
+        return filter(lambda s: s.node == self.node
+                      and s.author == username, self.signoffs)
     def signoffs_for_current_user(self):
         return self.signoffs_for_user(fromlocal(self.ui.username()))