# HG changeset patch # User Steve Losh # Date 1276926946 14400 # Node ID d2a44912c2f79d561a684b93012fd1d930b7392c # Parent 103828d0bc1aaa8b2a652acfd2c2a39cb7f94df1 tests: clean up comments diff -r 103828d0bc1a -r d2a44912c2f7 review/tests/test_comment.py --- a/review/tests/test_comment.py Sat Jun 19 00:17:31 2010 -0400 +++ b/review/tests/test_comment.py Sat Jun 19 01:55:46 2010 -0400 @@ -6,6 +6,8 @@ from mercurial import util as hgutil from mercurial.node import hex +# TODO: Figure out how to handle external editors nicely with nose. + a1, a2 = (messages.REVIEW_LOG_COMMENT_AUTHOR % '|').split('|') @with_setup(setup_reviewed_sandbox, teardown_sandbox) @@ -14,25 +16,6 @@ assert messages.REVIEW_LOG_COMMENTS % (0, 0) in output -# TODO: Figure out how to handle external editors nicely with nose. -#@with_setup(setup_reviewed_sandbox, teardown_sandbox) -#def test_blank_comment(): - #try: - #review(comment=True, message=' \t\n') - #except hgutil.Abort, e: - #error = str(e) - #assert messages.COMMENT_REQUIRES_MESSAGE in error - #else: - #assert False, 'The correct error message was not printed.' - - #try: - #review(comment=True, message=messages.COMMENT_EDITOR_MESSAGE) - #except hgutil.Abort, e: - #error = str(e) - #assert messages.COMMENT_REQUIRES_MESSAGE in error - #else: - #assert False, 'The correct error message was not printed.' - @with_setup(setup_reviewed_sandbox, teardown_sandbox) def test_comment_formatting(): review(comment=True, message=' \tTest comment one.\t ') diff -r 103828d0bc1a -r d2a44912c2f7 review/tests/test_signoff.py --- a/review/tests/test_signoff.py Sat Jun 19 00:17:31 2010 -0400 +++ b/review/tests/test_signoff.py Sat Jun 19 01:55:46 2010 -0400 @@ -4,6 +4,8 @@ from mercurial.node import hex from .. import messages +# TODO: Figure out how to handle external editors nicely with nose. + s1, s2 = (messages.REVIEW_LOG_SIGNOFF_AUTHOR % ('|', 'neutral')).split('|') sy1, sy2 = (messages.REVIEW_LOG_SIGNOFF_AUTHOR % ('|', 'yes')).split('|') sn1, sn2 = (messages.REVIEW_LOG_SIGNOFF_AUTHOR % ('|', 'no')).split('|') @@ -13,25 +15,6 @@ output = review() assert messages.REVIEW_LOG_SIGNOFFS % (0, 0, 0, 0) in output -# TODO: Figure out how to handle external editors nicely with nose. -#@with_setup(setup_reviewed_sandbox, teardown_sandbox) -#def test_blank_signoff(): - #try: - #review(signoff=True, message=' \t\n') - #except hgutil.Abort, e: - #error = str(e) - #assert messages.SIGNOFF_REQUIRES_MESSAGE in error - #else: - #assert False, 'The correct error message was not printed.' - - #try: - #review(signoff=True, message=messages.SIGNOFF_EDITOR_MESSAGE) - #except hgutil.Abort, e: - #error = str(e) - #assert messages.SIGNOFF_REQUIRES_MESSAGE in error - #else: - #assert False, 'The correct error message was not printed.' - @with_setup(setup_reviewed_sandbox, teardown_sandbox) def test_signoff_formatting(): review(signoff=True, message=' \tTest signoff one.\t ')