# HG changeset patch # User Steve Losh # Date 1267573826 18000 # Node ID 8a546e4e071e9b848d176f2fa6a3f6e7e3120ddf # Parent 99b7409c4b4555180dc0d6ca8cb0309b013d4fb4 Add and use ReviewChangeset.review_level_comments. diff -r 99b7409c4b45 -r 8a546e4e071e .venv --- /dev/null Thu Jan 01 00:00:00 1970 +0000 +++ b/.venv Tue Mar 02 18:50:26 2010 -0500 @@ -0,0 +1,1 @@ +hg-review diff -r 99b7409c4b45 -r 8a546e4e071e review/api.py --- a/review/api.py Tue Mar 02 18:43:34 2010 -0500 +++ b/review/api.py Tue Mar 02 18:50:26 2010 -0500 @@ -480,6 +480,12 @@ return ds + + @property + def review_level_comments(self): + """Comments on this changeset which aren't on a particular file.""" + return filter(lambda c: not c.filename, self.comments) + class _ReviewObject(object): """A base object for some kind of review data (a signoff or comment).""" @@ -657,3 +663,4 @@ return file_templates.SIGNOFF_FILE_TEMPLATE % ( self.author, rendered_date, self.node, self.opinion, self.message ) + diff -r 99b7409c4b45 -r 8a546e4e071e review/extension_ui.py --- a/review/extension_ui.py Tue Mar 02 18:43:34 2010 -0500 +++ b/review/extension_ui.py Tue Mar 02 18:50:26 2010 -0500 @@ -153,7 +153,7 @@ for signoff in rcset.signoffs: _print_signoff(signoff, before='\n') - review_level_comments = filter(lambda c: not c.filename, rcset.comments) + review_level_comments = rcset.review_level_comments if review_level_comments: ui.write('\n') for comment in review_level_comments: diff -r 99b7409c4b45 -r 8a546e4e071e review/web_templates/review.html --- a/review/web_templates/review.html Tue Mar 02 18:43:34 2010 -0500 +++ b/review/web_templates/review.html Tue Mar 02 18:50:26 2010 -0500 @@ -3,7 +3,7 @@ $ ctx = rd.target[rcset.node]

Changeset ${ ctx.rev() }: ${ ctx.description() }

-$ review_level_comments = filter(lambda c: not c.filename, rcset.comments) +$ review_level_comments = rcset.review_level_comments $for comment in review_level_comments: