# HG changeset patch # User Steve Losh # Date 1256169437 14400 # Node ID 1cc8e18b1b43ca823159a7cce01d5f3f7fef6da5 # Parent 5c274209a7ecfd83648d48a9109784a7b027d4d6 Add skipped line counts to diffs. diff -r 5c274209a7ec -r 1cc8e18b1b43 review/web_media/style.css --- a/review/web_media/style.css Wed Oct 21 19:31:46 2009 -0400 +++ b/review/web_media/style.css Wed Oct 21 19:57:17 2009 -0400 @@ -99,6 +99,9 @@ table tr.rem { background: #FBDBDA; } +table tr.skipped { + background: #ccc; +} div.diff .comment { margin-bottom: 0em; } \ No newline at end of file diff -r 5c274209a7ec -r 1cc8e18b1b43 review/web_templates/review.html --- a/review/web_templates/review.html Wed Oct 21 19:31:46 2009 -0400 +++ b/review/web_templates/review.html Wed Oct 21 19:57:17 2009 -0400 @@ -60,7 +60,15 @@ $ max_line = diff['max'] $ content = diff['content'] $ line_level_comments = filter(lambda c: c.filename == filename and c.lines, rcset.comments) + $ previous_n = -1 $for n, line in content: + $if n - 1 > previous_n: + $ skipped_count = n - previous_n + $if previous_n == -1: + $ skipped_count -= 1 + + … skipped ${ skipped_count } lines … + $ kind = 'rem' if line[0] == '-' else 'add' if line[0] == '+' else '' ${ line[1:] or ' ' } @@ -74,5 +82,11 @@
${ comment.message }
+ $ previous_n = n + $if previous_n < diff['max']: + $ skipped_count = diff['max'] - previous_n + + … skipped ${ skipped_count } lines … + \ No newline at end of file