# HG changeset patch # User Steve Losh # Date 1255566636 14400 # Node ID 0a9effb274b0c2bab2e856f9787fb7a2351d57a9 # Parent 93baa16777e904b65763e58fdba2deaf7e14289f Add review-level comments. diff -r 93baa16777e9 -r 0a9effb274b0 review/web_media/style.css --- a/review/web_media/style.css Wed Oct 14 20:21:21 2009 -0400 +++ b/review/web_media/style.css Wed Oct 14 20:30:36 2009 -0400 @@ -48,6 +48,24 @@ text-align: right; } +/* Comments. */ +.comment { + white-space: normal; + background: #FBEAD0; + border: 1px dashed #666; + font-family: Consolas, Monaco, "Courier New", Courier, monospace; + padding: 0.75em; + margin-bottom: 1.5em; +} +.comment div.avatar { + border: 1px solid black; + float: right; +} +.comment div.message { + margin-top: 1.5em; + white-space: pre; +} + /* Diffs. */ div.diff { overflow: auto; @@ -61,21 +79,6 @@ table tr.rem { background: #FBDBDA; } -table tr td.comment { - white-space: normal; - background: #F4FF68; - border-top: 1px dashed #666; - border-bottom: 1px dashed #666; - font-family: Consolas, Monaco, "Courier New", Courier, monospace; - padding: 0.75em; -} -table tr td.comment div.author { -} -table tr td.comment div.message { - margin-top: 1.5em; - white-space: pre; -} -table tr td.comment div.avatar { - border: 1px solid black; - float: right; +div.diff .comment { + margin-bottom: 0em; } \ No newline at end of file diff -r 93baa16777e9 -r 0a9effb274b0 review/web_templates/review.html --- a/review/web_templates/review.html Wed Oct 14 20:21:21 2009 -0400 +++ b/review/web_templates/review.html Wed Oct 14 20:30:36 2009 -0400 @@ -3,6 +3,16 @@ $ ctx = rd.target[rcset.node]

Changeset ${ ctx.rev() }: ${ ctx.description() }

+$ review_level_comments = filter(lambda c: not c.filename, rcset.comments) +$for comment in review_level_comments: +
+
+
+ +
${ comment.message }
+
+
+ $for filename, diff in rcset.diffs().iteritems():

${ filename }